Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws 0.8.0 #341

Closed
wants to merge 1 commit into from
Closed

Conversation

johanneswuerbach
Copy link
Contributor

iojs 3 compatibility

Related socketio/engine.io-client#411

@rmg
Copy link

rmg commented Aug 21, 2015

Looks like it won't be as easy as just updating the version in package.json :-(

To save the digging, the failure on Travis is on this line:

expect(conn.request.headers[h]).to.equal(headers[h]);

@Nibbler999
Copy link
Contributor

The test failure is unrelated.

@shinnn
Copy link
Contributor

shinnn commented Aug 23, 2015

@Nibbler999 is right.

@CxRes
Copy link

CxRes commented Aug 27, 2015

@rauchg: Can you please fix this asap. It is holding a lot of us back!!!!!! Also please bump the version number.

@johanneswuerbach
Copy link
Contributor Author

Rebased and passing now :-)

@rmg
Copy link

rmg commented Sep 8, 2015

Since node-v4.0.0 was just released, this is now even more useful to land/release.

@kriswill
Copy link

kriswill commented Sep 8, 2015

+1 This is blocking the world for a lot of people.

@Cap32
Copy link

Cap32 commented Sep 9, 2015

+1 This is blocking the world for a lot of people.

@lygstate
Copy link

lygstate commented Sep 9, 2015

That's a lot of annoy. ws are failed too much.

@iamstarkov
Copy link

So what about bringing socketio to the [email protected]?

@SpainTrain
Copy link

Restating the obvious: Until this lands, engine.io and its dependents will be uninstallable under node v4.0.0 (latest stable node).

@rauchg @nkzawa can you please merge and release this update? That would be so ❤️

FWIW, in addition to breaking dependent packages, this is causing administrative overhead for the maintainers of your dependencies due to users filing false positive issues (e.g. websockets/bufferutil#15, websockets/utf-8-validate#13)

@johanneswuerbach
Copy link
Contributor Author

Yeah, looks like it was bumped now.

@SpainTrain
Copy link

@johanneswuerbach
Copy link
Contributor Author

Strange looks like 1.5.3...master it was only bumped in a tag

@marcelaraujo
Copy link

iojs 3 compatibility
@SpainTrain
Copy link

@marcelaraujo
Copy link

@SpainTrain
Copy link

The package in the npm registry has the correct package.json, so npm i works.

Thanks @rauchg!

@marcelaraujo
Copy link

@SpainTrain Which version are you used?

@SpainTrain
Copy link

@SpainTrain Which version are you used?

$ npm cache clean
$ npm info engine.io version
1.5.3

$ npm info engine.io dependencies

{ base64id: '0.1.0',
  debug: '1.0.3',
  'engine.io-parser': '1.2.1',
  ws: '0.8.0' }

@marcelaraujo
Copy link

Tks sir!

@nkzawa
Copy link
Contributor

nkzawa commented Sep 10, 2015

Fixed 1a115d3

@nkzawa nkzawa closed this Sep 10, 2015
darrachequesne pushed a commit that referenced this pull request May 8, 2020
IE10 should prefer using XHR2 over XDR because it's safer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.