-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ws 0.8.0 #341
ws 0.8.0 #341
Conversation
Looks like it won't be as easy as just updating the version in package.json :-( To save the digging, the failure on Travis is on this line: Line 2204 in a4dcf19
|
The test failure is unrelated. |
@Nibbler999 is right. |
@rauchg: Can you please fix this asap. It is holding a lot of us back!!!!!! Also please bump the version number. |
286de62
to
0afcb53
Compare
Rebased and passing now :-) |
Since node-v4.0.0 was just released, this is now even more useful to land/release. |
+1 This is blocking the world for a lot of people. |
+1 This is blocking the world for a lot of people. |
That's a lot of annoy. ws are failed too much. |
So what about bringing socketio to the [email protected]? |
Restating the obvious: Until this lands, engine.io and its dependents will be uninstallable under node v4.0.0 (latest stable node). @rauchg @nkzawa can you please merge and release this update? That would be so ❤️ FWIW, in addition to breaking dependent packages, this is causing administrative overhead for the maintainers of your dependencies due to users filing false positive issues (e.g. websockets/bufferutil#15, websockets/utf-8-validate#13) |
Yeah, looks like it was bumped now. |
Don't see it on master - https://github.com/socketio/engine.io/blob/master/package.json#L29 |
Strange looks like 1.5.3...master it was only bumped in a tag |
0afcb53
to
f7cdc33
Compare
The package in the npm registry has the correct Thanks @rauchg! |
@SpainTrain Which version are you used? |
|
Tks sir! |
Fixed 1a115d3 |
IE10 should prefer using XHR2 over XDR because it's safer
iojs 3 compatibility
Related socketio/engine.io-client#411